debug: Allow type-specification of JSON output for cortex-debug #2393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2393 +/- ##
==========================================
+ Coverage 64.48% 64.51% +0.03%
==========================================
Files 207 207
Lines 19592 19630 +38
==========================================
+ Hits 12633 12665 +32
- Misses 5867 5871 +4
- Partials 1092 1094 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
alessio-perugini
approved these changes
Oct 31, 2023
|
Will this work with arrays? If yes, please update the example in the PR description. Thanks! I am going to use this version downstream: arduino/vscode-arduino-tools#41. |
|
I've upgraded the conversion process, now it can:
This change should make it possible to build any JSON from properties. |
alessio-perugini
approved these changes
Oct 31, 2023
cmaglie
added a commit
that referenced
this pull request
Oct 31, 2023
* debug: Allow type-specification of JSON output for cortex-debug * Improved JSON properties generation
|
@kittaakos I've cherrypicked this PR in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
In the cortex-debug section of the debug info, all the values are converted by default to a string in the resulting JSON.
Now, If another type is needed, the value can be prefixed with the tags
[boolean],[number], or[object]to force a specific type in the JSON, for example:will result in the following JSON:
{ "aBoolean": true, "anNumber": 10, "anotherNumber": 10.2, "anObject": { "boolean": true, "key": "value" } }What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change, and is titled accordingly?
Other information